Update Elastic-Charts to 13.0.0 #2381
Conversation
Move grid line styles into the theme and remove from the examples
|
Are dependency upgrades considered breaking if the dependency had breaking changes? |
Move grid line styles into the theme and remove from the examples
…into update-charts-12.0.0
| <Settings theme={euiTheme} />`} | ||
| </EuiCodeBlock> | ||
| <EuiCallOut title="Kibana engineers" iconType="logoKibana"> | ||
| <p> | ||
| We provide a plugin utility for ease of pulling in the correct |
There was a problem hiding this comment.
My only commentary would be that this shouldn't link to a pull request, which is essentially a snapshot from a previous time. You might want to consider adding a readme (in absence of proper dev docs there) to your plugin, then linking to it from here.
There was a problem hiding this comment.
Yeah I think I was just being lazy. I'll go create a readme...
There was a problem hiding this comment.
Waiting on approval of elastic/kibana#46736
Depends what kind of dependency it is. In this case the dependency is listed in |
|
Just curious what the plan is for future updates. Wait for a bump in Kibana and react to it? Watch the release notes and upgrade when new/breaking changes are introduced? Catch every release? |
|
Ideally, the elastic-charts team would I'm open to suggestions. |
|
I updated my comment above as I meant to say the charts team would ideally take care of updates. |
|
I updated the Kibana callout to just reference a link to the Readme (removing the code portion). This way we don't have to maintain that code in two places. |
* Update to Charts 13.0.0 * Move grid line styles into the theme and remove from the examples * Adding scales in even though they’re the default * Fix inheritence of code block font sizes
This removed the necessity of specifying the grid styles outside of the theme object and a simpler way to get rid of the axes label ticks. I also added a callout for Kibana engineers over how to use the Kibana plugin for getting the EUI theme.
Also
This also contains a fix where EuiCodeBlock's text size wasn't changing based on the fontSize prop if they occurred inside a EuiText wrapper. I ensured proper inheritance for the component itself while reducing specificity of the EuiText sizing class by removing the chained selectors.
Checklist
[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes